Repository navigation
[installation] installer: adopt Omarchy mimeapps.list - #296
Closed
eduardoaugustolb wants to merge 1 commit into
Closed
eduardoaugustolb wants to merge 1 commit into
eduardoaugustolb wants to merge 1 commit into
Conversation
Note: Fixed: Ryoku now installs on Omarchy when it owns the system mimeapps list
Collaborator
|
Thanks for digging into this and for the clean diff. We went a different way here: instead of overwriting omarchy-settings' file, the default-app map moved up the XDG chain to /usr/local/share/applications/mimeapps.list, which no distro package owns. Same end result for the install, but it doesn't take a file that belongs to Omarchy, and it covers the ISO path and plain updates too, not just the script installer. That's already on the dev line and closes #295, so I'm closing this one out. The regression test idea was good; ours now asserts the new path instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add
/usr/share/applications/mimeapps.listto the standalone Arch installer overwrite glob. Omarchy owns this path, whileryoku-desktopprovides Ryoku default app associations there; pacman can now adopt the path instead of aborting the install. Add regression coverage and update the installer changelog, committed binary, and checksum.Closes #295
Verification
GOCACHE=/tmp/ryoku-installer-gocache GOMODCACHE=/tmp/ryoku-installer-gomodcache go test ./...sha256sum -c ryoku-shell-install.sha256